Conversation
setting common highlight colors and font sizes
- add group of currently used to top - new meetings should default to current tsml_timezone setting, if set
Also it's timezones, not timzones
gkovats
requested review from
Copilot and
joshreisner
and removed request for
Copilot
assets/src/_tsml-jquery-ui.scss
Outdated
| @@ -0,0 +1,54 @@ | |||
| $selected: #1980EC; | |||
There was a problem hiding this comment.
this was a tsml-jquery-us.css file, changed to SCSS just to get those color variables and do some nested CSS declarations, but it's not important
There was a problem hiding this comment.
the larger font size is great, but i'm seeing this menu pass behind the map
There was a problem hiding this comment.
still seeing this - to reproduce you'll need enough locations in your database and you'll want to type a string in the Location field that matches enough of them
joshreisner
left a comment
joshreisner
left a comment
There was a problem hiding this comment.
looks great, thanks! just some minor PHP notice / css feedback
assets/src/_tsml-jquery-ui.scss
Outdated
| @@ -0,0 +1,54 @@ | |||
| $selected: #1980EC; | |||
There was a problem hiding this comment.
the larger font size is great, but i'm seeing this menu pass behind the map
includes/functions_timezone.php
Outdated
| if (!in_array($timezone, $timezones)) { | ||
| continue; | ||
| } | ||
| $city = array_pop(explode('/', $timezone, 2)); |
There was a problem hiding this comment.
seeing this php notice
|
hey @gkovats i'm still seeing the autocomplete issue on mac safari and firefox: 
if i bump the z-index to 1000 then it appears in front of the map: 
seeing this on the search dropdown (probably unrelated to this change): 
if i bump that z-index to 1010: 
i'm also seeing a problem with the autocomplete in legacy: 
|
|
i pushed a change (hope that's ok) to fix the z-index issues. i'll publish this branch on our demo site now to see if we see this autocomplete issue there too |
|
yeah, it also looks kind of jacked there: https://demo.code4recovery.org/meetings im happy to help try to fix it but maybe another option to consider is to revert the changes to the autocomplete since they're not super relevant to this PR |
2 participants
Addresses #1774
tsml_get_meetings()now uses the TMSL set timezone as a default value for meetings without a timezoneAlso for no good reason
npm audit fixto address some lib warnings